added config path to Service interface

[jasmingacic]

For some sort of automations it is practical to get information where service files are stored.

[kardianos]

This may be alright. But, the ConfigPath would need to be a separate interface; right now it breaks windows I think.

[jasmingacic]

I haven't tested it with Windows. Do you have a suggestion how to avoid breaking the build for Windows?

…

On Thu, Dec 17, 2020, 18:30 Daniel Theophanes ***@***.***> wrote: This may be alright. But, the ConfigPath would need to be a separate interface; right now it breaks windows I think. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#255 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7RER3CBVILCWRFDTOKPA3SVI52HANCNFSM4U7ZSOSA> .

[kardianos]

GOOS=windows go build .

[jasmingacic]

@kardianos Fixed it for windows.

I also wanted to check with you if I did it right. In most of cases I renamed configPath() string, error to ConfigPath()string and refactored accordingly. Do you think that's the best approach or maybe it should be done differently?

[kardianos]

So yes, for this change to happen:

• Make the ConfigPath return (string error).
• Remove it from the service interface.
• Make an optional interface it may support (windows won't implement).
• Require a type assertion for it to use.

[jasmingacic]

@kardianos Do you mind if I call the optional interface ConfigInfo? (I can't think of a better name right now)

[kardianos]

No. How about Metaer :) or ConfigPather

hmmm, maybe PatholoConfiger ... I'm getting worse.

Not Config, but maybe not PatholoConfiger either.

[jasmingacic]

I think ConfigInfo sound ok then we can have ConfigPath and what other information might be stored there.

[jasmingacic]

@kardianos I just refactored it to use the optional interface ConfigInfo, later we can decide on the name.

[coveralls]

Coverage increased (+1.1%) to 13.9% when pulling f509d03 on jasmingacic:configpath into ef35c56 on kardianos:master.

[coveralls]

Coverage decreased (-0.3%) to 12.525% when pulling 20d92e3 on jasmingacic:configpath into ef35c56 on kardianos:master.

[kardianos]

Ensure you run
go mod tidy
and go fmt
prior to commit.

[jasmingacic]

@kardianos can you help me out with the test for ConfigPath how do you want to have it implemented?

[kardianos]

Go ahead and read the diffs and correct the other OSes. Also, no need to have an exported method and un-exported method that do the same thing. Just use the exported method.

[jasmingacic]

So getting config value like this is fine?

	_, err = s.(service.ConfigInfoer).ConfigPath()

Also I'm not sure what you mean by read the diffs and correct the other OSes, I already did that. Unless I'm missing something.

[kardianos]

Please read all my comments carefully this time. Please read your diffs carefully.

[jasmingacic]

Is this test valid?

[jasmingacic]

ping