Fix/1945 fix for wrong validation being triggered#1946
Merged
EItanya merged 2 commits intoJun 1, 2026
Merged
Conversation
…#1945) Signed-off-by: Gaurav Shinde <shindegauravpict@gmail.com>
Signed-off-by: Gaurav Shinde <shindegauravpict@gmail.com>
6 tasks
EItanya
approved these changes
Jun 1, 2026
peterj
added a commit
that referenced
this pull request
Jun 1, 2026
…peterj/substrate * 'peterj/substrate' of github.com:kagent-dev/kagent: Fix AgentHarness CI failures Split AgentHarness controllers by runtime Simplify substrate actor cleanup wiring Refine substrate AgentHarness lifecycle fix failing helm unit tests commenting out the substrate section in values move write ops to writer-role make linter happy pr feedback move startup script to a template split substrate and openshell, use the secrets in substrate fork for modelconfig/channels clean up ui/gateway stuff (use base path from openclaw) fix up the optional/non-optional types in the crd/values file substrate wip fix(compaction): preserve namespaced tool names in LLM summarizer prompt (#1907) Fix/1945 fix for wrong validation being triggered (#1946) fix(security): replace shell-templated skills-init with Go binary (#1842) (#1928) Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
fix(ui): don't require API key when creating Ollama model (#1945)
Description:
What
Creating an Ollama model failed validation with "API key is required …",
blocking creation even though Ollama needs no key.
Fixes #1945
Cause
validateFormdetected Ollama viaselectedCombinedModel.startsWith('ollama::'), but the combined value is built from the provider key and is actually"Ollama::<model>"(capital O) — so the check never matched and the API-key requirement fired.Fix
Detect Ollama from the selected provider instead, case-insensitively:
selectedProvider?.type?.toLowerCase() === 'ollama'.Also removed a leftover debug
console.log.Testing
Screen.Recording.2026-05-30.113513.mp4