JEP-0011: Protobuf Introspection and Interface Generation#565
JEP-0011: Protobuf Introspection and Interface Generation#565kirkbrauer wants to merge 2 commits intomainfrom
Conversation
Propose adding protobuf introspection to allow non-Python clients to discover driver APIs. Introduces FileDescriptorProto as the schema format and enables bidirectional CLI tooling (jmp proto export, jmp proto generate, jmp proto check).
📝 WalkthroughWalkthroughDocumentation infrastructure for Jumpstarter Enhancement Proposals (JEPs) is established by introducing a new index page that catalogs JEPs with their status and authors, while updating the contributing guide's table of contents to reference this new documentation section. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| | Field | Value | | ||
| | ----------------- | ----------------------------------------------------- | | ||
| | **JEP** | 0011 | |
There was a problem hiding this comment.
why 0011? :D wouldn't it be 2 ?
There was a problem hiding this comment.
JEP-0-9 are reserved for process improvements and JEP-10 already exists.
|
@ambient-code Please update the TOCTREE and main index file for the JEPs to include this proposal. |
Add a JEPs index page listing JEP-0011 and include it in the contributing section toctree so proposals are discoverable from the main documentation navigation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Done — added a JEPs index page at |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
python/docs/source/internal/jeps/index.md (1)
3-6: Consider linking the JEP process doc here.To reduce ambiguity for first-time proposal authors, add a direct link to the JEP process document in this intro section.
Based on learnings, the project’s process document is located at `jeps/JEP-0000-jep-process.md`.Suggested doc tweak
JEPs are the primary mechanism for proposing significant changes to Jumpstarter. Each JEP is submitted as a pull request containing a Markdown document that describes the motivation, design, and implementation plan for the proposed change. +For process details, see +[`JEP-0000: JEP Process`](../../../jeps/JEP-0000-jep-process.md).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@python/docs/source/internal/jeps/index.md` around lines 3 - 6, Add a direct link to the JEP process document in the intro paragraph of the JEP index so first-time authors can find the process easily; edit the text that begins "JEPs are the primary mechanism..." in the jeps index and append or replace a sentence with a clear relative link to the process doc (jeps/JEP-0000-jep-process.md) and a short phrase like "see the JEP process document" so readers can jump directly to the guidelines.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@python/docs/source/internal/jeps/index.md`:
- Around line 3-6: Add a direct link to the JEP process document in the intro
paragraph of the JEP index so first-time authors can find the process easily;
edit the text that begins "JEPs are the primary mechanism..." in the jeps index
and append or replace a sentence with a clear relative link to the process doc
(jeps/JEP-0000-jep-process.md) and a short phrase like "see the JEP process
document" so readers can jump directly to the guidelines.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a9f28d7f-141f-4ae5-b20b-88468446d8a2
📒 Files selected for processing (3)
python/docs/source/contributing.mdpython/docs/source/internal/jeps/JEP-0011-protobuf-introspection-interface-generation.mdpython/docs/source/internal/jeps/index.md
Propose adding protobuf introspection to allow non-Python clients to discover driver APIs. Introduces FileDescriptorProto as the schema format and enables bidirectional CLI tooling (jmp proto export, jmp proto generate, jmp proto check).
For a full reference implementation, please see: https://github.com/jumpstarter-dev/jumpstarter/tree/jep-11-protobuf-introspection