Skip to content

Remove callback_exception#325

Merged
odow merged 2 commits intomasterfrom
od/callback-error
May 1, 2026
Merged

Remove callback_exception#325
odow merged 2 commits intomasterfrom
od/callback-error

Conversation

@odow
Copy link
Copy Markdown
Member

@odow odow commented May 1, 2026

There was actually a bug here: we passed cb_data in the try-catch, but cb in the invalid state check. So errors during the callback actually errored because .callback_data isn't a field. Rather than split the functions, I just made them in-line.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.61%. Comparing base (405a031) to head (ea6622c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   98.61%   98.61%   -0.01%     
==========================================
  Files           3        3              
  Lines        2524     2523       -1     
==========================================
- Hits         2489     2488       -1     
  Misses         35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow odow merged commit 3f08ab2 into master May 1, 2026
16 checks passed
@odow odow deleted the od/callback-error branch May 1, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant