Move constraint bridges to a Bridge.Constraint submodule#756
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 94.32% 94.33% +<.01%
==========================================
Files 56 57 +1
Lines 6225 6226 +1
==========================================
+ Hits 5872 5873 +1
Misses 353 353
Continue to review full report at Codecov.
|
coroa
added a commit
to coroa/JuMP.jl
that referenced
this pull request
Jul 8, 2019
coroa
added a commit
to coroa/JuMP.jl
that referenced
this pull request
Aug 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tidy up is needed before adding objective (#529) and variable bridges (#710).
This is breaking for bridges as
MOI.Bridges.AbstractBridgeis nowMOI.Bridges.Constraint.AbstractBridge. Same thing forconcrete_bridge_typeandadded_constraint_types.