Skip to content

Commit 35ee88e

Browse files
authored
Merge pull request #1163 from dimaqq/multiple-juju-versions
#1163 Integration tests against Juju 3.1, 3.3, 3.4, 3.5 (was: 3.4) Unit tests against Python 3.8~3.13 (was: 3.9~3.10) Notes: Juju 3.6 deprecated some bases (?) and many integration tests fail. Given that it's in beta, deferring that to a separate PR.
2 parents 0e8c45f + c7abedc commit 35ee88e

1 file changed

Lines changed: 30 additions & 2 deletions

File tree

.github/workflows/test.yaml

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@ name: Testing
22

33
on: [push, pull_request, workflow_dispatch]
44

5+
concurrency:
6+
group: ${{ github.workflow }}-${{ github.ref }}
7+
cancel-in-progress: true
8+
59
jobs:
610
lint:
711
name: Linter
@@ -69,8 +73,12 @@ jobs:
6973
strategy:
7074
matrix:
7175
python:
76+
- "3.8"
7277
- "3.9"
7378
- "3.10"
79+
- "3.11"
80+
- "3.12"
81+
- "3.13"
7482
steps:
7583
- name: Check out code
7684
uses: actions/checkout@v4
@@ -95,6 +103,18 @@ jobs:
95103
# save some resources for now.
96104
# - "3.9"
97105
- "3.10"
106+
juju:
107+
- "3.1/stable"
108+
- "3.3/stable"
109+
- "3.4/stable"
110+
- "3.5/stable"
111+
# A bunch of tests fail with juju.errors.JujuError: base: ubuntu@15.04/stable
112+
# * test_subordinate_units
113+
# * test_destroy_unit
114+
# * test_ssh
115+
# * ...
116+
# - "3.6/beta"
117+
continue-on-error: false # ultimately fail a run if one of the matrix combinations fails
98118
steps:
99119
- name: Check out code
100120
uses: actions/checkout@v4
@@ -106,7 +126,7 @@ jobs:
106126
uses: charmed-kubernetes/actions-operator@main
107127
with:
108128
provider: lxd
109-
juju-channel: 3.4/stable
129+
juju-channel: ${{ matrix.juju }}
110130
# 2023-01-11 Commented until we discover a
111131
# clear approach for this.
112132
# - name: Set proxy in controller
@@ -138,6 +158,7 @@ jobs:
138158
- name: Run integration
139159
# Force one single concurrent test
140160
run: tox -e integration
161+
continue-on-error: true # don't fail early, let other matrix combinations get tested
141162

142163
integration-quarantine:
143164
name: Quarantined Integration Tests
@@ -148,6 +169,12 @@ jobs:
148169
matrix:
149170
python:
150171
- "3.10"
172+
juju:
173+
- "3.1/stable"
174+
- "3.3/stable"
175+
- "3.4/stable"
176+
- "3.5/stable"
177+
continue-on-error: false # ultimately fail the run if one of the matrix combinations fails
151178
steps:
152179
- name: Check out code
153180
uses: actions/checkout@v3
@@ -159,6 +186,7 @@ jobs:
159186
uses: charmed-kubernetes/actions-operator@main
160187
with:
161188
provider: lxd
162-
juju-channel: 3.4/stable
189+
juju-channel: ${{ matrix.juju }}
163190
- name: Run integration
164191
run: tox -e integration-quarantine
192+
continue-on-error: true # don't fail early, let other matrix combinations get tested

0 commit comments

Comments
 (0)