Skip to content

Commit c7abedc

Browse files
committed
ci: udpate continue markers and explain why
1 parent bed9eae commit c7abedc

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/test.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ jobs:
114114
# * test_ssh
115115
# * ...
116116
# - "3.6/beta"
117-
continue-on-error: false # don't ignore if tests against some juju version fail
117+
continue-on-error: false # ultimately fail a run if one of the matrix combinations fails
118118
steps:
119119
- name: Check out code
120120
uses: actions/checkout@v4
@@ -158,7 +158,7 @@ jobs:
158158
- name: Run integration
159159
# Force one single concurrent test
160160
run: tox -e integration
161-
continue-on-error: true # so that other juju versions are tested
161+
continue-on-error: true # don't fail early, let other matrix combinations get tested
162162

163163
integration-quarantine:
164164
name: Quarantined Integration Tests
@@ -174,6 +174,7 @@ jobs:
174174
- "3.3/stable"
175175
- "3.4/stable"
176176
- "3.5/stable"
177+
continue-on-error: false # ultimately fail the run if one of the matrix combinations fails
177178
steps:
178179
- name: Check out code
179180
uses: actions/checkout@v3
@@ -188,4 +189,4 @@ jobs:
188189
juju-channel: ${{ matrix.juju }}
189190
- name: Run integration
190191
run: tox -e integration-quarantine
191-
continue-on-error: true # so that other juju versions are tested
192+
continue-on-error: true # don't fail early, let other matrix combinations get tested

0 commit comments

Comments
 (0)