Skip to content

ChineseTraditional.isl: Normalize punctuation and fix Simplified Chinese remnants#596

Open
GoneTone wants to merge 2 commits into
jrsoftware:mainfrom
GoneTone:improve-chinesetraditional-translation
Open

ChineseTraditional.isl: Normalize punctuation and fix Simplified Chinese remnants#596
GoneTone wants to merge 2 commits into
jrsoftware:mainfrom
GoneTone:improve-chinesetraditional-translation

Conversation

@GoneTone

@GoneTone GoneTone commented Jun 5, 2026

Copy link
Copy Markdown

Summary

This PR improves the unofficial Traditional Chinese (Taiwan) translation in Files/Languages/Unofficial/ChineseTraditional.isl. The changes normalize punctuation to proper Traditional Chinese typographic conventions and replace leftover Simplified Chinese wording and terminology.

No message keys were added or removed; only the translated values changed.

Changes

Punctuation normalization

  • Use the fullwidth colon instead of the halfwidth : in Chinese text (for example LastErrorMessage, ReadyMemoDir, PathLabel, AdditionalIcons).
  • Use the fullwidth question mark instead of the halfwidth ? (for example ExitSetupMessage, ConfirmDeleteSharedFile2).
  • Use corner brackets 「」 instead of curly quotes “” for quoting (for example ErrorCreatingDir, FileNotInDir2, UninstallNotFound).

Simplified Chinese remnants fixed

  • Download wording: 正在下载文件 to 正在下載檔案.
  • Wizard terminology: 嚮導 to 精靈.
  • Extraction wording: 解壓 to 解壓縮.
  • Source/file naming: 源文件 to 來源檔案, 檔大小 to 檔案大小, 檔標籤 to 檔案標籤, 檔雜湊值 to 檔案雜湊值, 檔案名 to 檔案名稱.
  • Other corrections: 網絡 to 網路, 沖突 to 衝突, 下麵 to 下面, 注冊 to 註冊, 變量 to 參數.

Terminology consistency

  • Unify terms such as 檔案, 驗證, and related wording across messages.

…ese remnants.

- Use fullwidth colon and question mark in Chinese text.
- Use corner brackets instead of curly quotes for quoting.
- Fix Simplified Chinese leftovers, for example download wording,
  wizard terminology, extraction wording, and source/file naming.
- Improve terminology consistency.
@CLAassistant

CLAassistant commented Jun 5, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@martijnlaan2

Copy link
Copy Markdown

Thank you, looks like a clear improvement. Did you contact the maintainer as requested on our translations page?

Here are some additional findings:

  1. ConfirmDeleteSharedFile2 (line 393): the value contains a %1 (and an extra
    %n%n) that the English message does not have. Setup assigns this message
    straight to the dialog body label without substituting arguments, so the
    literal text "%1" would be displayed. The file name is shown separately via
    SharedFileNameLabel.
  2. FileExistsOverwriteExisting / FileExistsKeepExisting (lines 342-343): the
    accelerators don't match the English. Overwrite (342) has no &, and Keep (343)
    carries "(&O)" where the English is "&Keep". The parallel ExistingFileNewer
    messages (347-348) use &O for Overwrite and &K for Keep.
  3. ExitSetupMessage (line 92): the English has two paragraph breaks (%n%n after
    "...installed." and after "...installation."); the translation has one, so the
    last two sentences run together.
  4. InvalidPath (line 169): the English lays the example out over separate lines
    ("for example:%n%nC:\APP%n%nor a UNC path in the form:%n%n\server\share", six
    %n); the translation collapses it to one line (two %n).
  5. WelcomeLabel2 (line 128): a clause and an intensifier were added that the
    English does not have ("以避免與安裝程式發生衝突" / "to avoid conflicts with
    Setup", and "強烈" / "strongly"). The English is only "It is recommended that
    you close all other applications before continuing."
  6. CloseApplications (line 253): "自動" (automatically) is dropped; the English is
    "&Automatically close the applications".
  7. DownloadingLabel2 (line 225): "額外" (additional) is added; the English is only
    "Downloading files...".
  8. RetryCancelCancel (line 292): an accelerator "(&C)" is present where the
    English "Cancel" has none (ButtonCancel on line 105 correctly has none).
  9. LanguageName (lines 18, 20): defined twice. Line 20
    ("<7e41><9ad4><4e2d><6587>") is not commented out despite the line-19 comment
    ("uncomment next line"). Both resolve to 繁體中文, so it works, but line 20 is
    redundant and uses the obsolete escape syntax; the literal characters on
    line 18 are preferred.

- ConfirmDeleteSharedFile2: remove the literal %1 and the extra %n%n. Setup
  assigns this message straight to the dialog body label without substituting
  arguments, so %1 would be shown literally. The file name is displayed
  separately via SharedFileNameLabel.
- FileExistsOverwriteExisting / FileExistsKeepExisting: fix accelerators to
  match the English and the parallel ExistingFileNewer messages (&O for
  Overwrite, &K for Keep).
- ExitSetupMessage: add the missing %n%n so the last two sentences no longer
  run together.
- InvalidPath: lay the example out over separate lines to match the English.
- WelcomeLabel2: drop the added intensifier and clause not present in the
  English.
- CloseApplications: restore the dropped "automatically".
- DownloadingLabel2: remove the added "additional".
- RetryCancelCancel: remove the accelerator the English does not have.
- LanguageName: remove the redundant duplicate that uses the obsolete escape
  syntax, keeping the literal characters.
@GoneTone

GoneTone commented Jun 5, 2026

Copy link
Copy Markdown
Author

Thank you, looks like a clear improvement. Did you contact the maintainer as requested on our translations page?

Here are some additional findings:

  1. ConfirmDeleteSharedFile2 (line 393): the value contains a %1 (and an extra
    %n%n) that the English message does not have. Setup assigns this message
    straight to the dialog body label without substituting arguments, so the
    literal text "%1" would be displayed. The file name is shown separately via
    SharedFileNameLabel.
  2. FileExistsOverwriteExisting / FileExistsKeepExisting (lines 342-343): the
    accelerators don't match the English. Overwrite (342) has no &, and Keep (343)
    carries "(&O)" where the English is "&Keep". The parallel ExistingFileNewer
    messages (347-348) use &O for Overwrite and &K for Keep.
  3. ExitSetupMessage (line 92): the English has two paragraph breaks (%n%n after
    "...installed." and after "...installation."); the translation has one, so the
    last two sentences run together.
  4. InvalidPath (line 169): the English lays the example out over separate lines
    ("for example:%n%nC:\APP%n%nor a UNC path in the form:%n%n\server\share", six
    %n); the translation collapses it to one line (two %n).
  5. WelcomeLabel2 (line 128): a clause and an intensifier were added that the
    English does not have ("以避免與安裝程式發生衝突" / "to avoid conflicts with
    Setup", and "強烈" / "strongly"). The English is only "It is recommended that
    you close all other applications before continuing."
  6. CloseApplications (line 253): "自動" (automatically) is dropped; the English is
    "&Automatically close the applications".
  7. DownloadingLabel2 (line 225): "額外" (additional) is added; the English is only
    "Downloading files...".
  8. RetryCancelCancel (line 292): an accelerator "(&C)" is present where the
    English "Cancel" has none (ButtonCancel on line 105 correctly has none).
  9. LanguageName (lines 18, 20): defined twice. Line 20
    ("<7e41><9ad4><4e2d><6587>") is not commented out despite the line-19 comment
    ("uncomment next line"). Both resolve to 繁體中文, so it works, but line 20 is
    redundant and uses the obsolete escape syntax; the literal characters on
    line 18 are preferred.

Thanks for the review. I've updated the translation. I've also just contacted the translation's maintainer.

@martijnlaan

Copy link
Copy Markdown
Member

Did you get a response?

@GoneTone

Copy link
Copy Markdown
Author

Not yet, no response yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants