Optimize bDelayPan and divisions#3706
Open
ann0see wants to merge 1 commit into
Open
Conversation
ann0see
commented
May 20, 2026
Comment on lines
-1120
to
-1129
| if ( ( i & 1 ) == 0 ) | ||
| { | ||
| // if even : left channel | ||
| vecfIntermProcBuf[i] += vecsData[i] * fGainL; | ||
| } | ||
| else | ||
| { | ||
| // if odd : right channel | ||
| vecfIntermProcBuf[i] += vecsData[i] * fGainR; | ||
| } |
Member
Author
There was a problem hiding this comment.
Got rid of modulo computation
ann0see
force-pushed
the
opt1/mixencodetx
branch
2 times, most recently
from
c6038cc to
ccd6f5e
Compare
ann0see
commented
May 20, 2026
Member
Author
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
The function is still way too complex imo.
Member
Author
|
To avoid having the clipping to short twice, we may want someting like Maybe... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Moves delay pan checking slightly out of loop as this setting does not change often.
Moreover replaces some divisions with *0.5 and remove some modulo computations
CHANGELOG: Server: Optimize mixing
Context: Fixes an issue?
Related to: #3662
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Tested and it seems to work, I still would like an external test.
Checklist