Potential fixes for 4 code quality findings#3702
Draft
ann0see wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Member
Author
|
I don't think everything here is valid. |
ann0see
commented
May 20, 2026
Comment on lines
+859
to
+861
| QSoundEffect sf; | ||
| sf.setSource ( QUrl::fromLocalFile ( ":sounds/res/sounds/new_message.wav" ) ); | ||
| sf.play(); |
Member
Author
There was a problem hiding this comment.
This may be valid. Stack vs heap allocation?
ann0see
commented
May 20, 2026
Comment on lines
1449
to
1458
| case MT_BAR_NARROW: | ||
| lbrInputLevelL->SetLevelMeterType ( CLevelMeter::MT_BAR_WIDE ); | ||
| lbrInputLevelR->SetLevelMeterType ( CLevelMeter::MT_BAR_WIDE ); | ||
| lbrInputLevelL->SetLevelMeterType ( CLevelMeter::MT_BAR_NARROW ); | ||
| lbrInputLevelR->SetLevelMeterType ( CLevelMeter::MT_BAR_NARROW ); | ||
| break; | ||
|
|
||
| case MT_LED_ROUND_SMALL: | ||
| lbrInputLevelL->SetLevelMeterType ( CLevelMeter::MT_LED_ROUND_BIG ); | ||
| lbrInputLevelR->SetLevelMeterType ( CLevelMeter::MT_LED_ROUND_BIG ); | ||
| lbrInputLevelL->SetLevelMeterType ( CLevelMeter::MT_LED_ROUND_SMALL ); | ||
| lbrInputLevelR->SetLevelMeterType ( CLevelMeter::MT_LED_ROUND_SMALL ); | ||
| break; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies 4/4 suggestions from code quality AI findings.
Only for review. We should then decide if we actually have a memory leak here.