Default reported OS to Unix if not Linux (e.g. FreeBSD)

[softins]

Short description of changes

Make default reported OS be Unix (OT_UNIX was already defined, so is not new here) if the build is not Windows, Mac, iOS, Android or Linux. For example FreeBSD.

CHANGELOG: Server: Report OS as Unix if not Windows, Mac, iOS, Android or Linux.

Context: Fixes an issue?

When recently testing a FreeBSD build, it was reporting its OS as Linux. It should say the more generic Unix.

Does this change need documentation? What needs to be documented and how?

Probably not. The OS is not displayed anywhere within Jamulus, so this only affects Jamulus Explorer and similar sites.

Status of this Pull Request

Ready and tested on both Linux and FreeBSD

What is missing until this pull request can be merged?

Only review

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[ann0see]

Looks sensible. Not tested but it looks trivial.

[pljones]

Note that this introduces for the first time the possibility of GetOperatingSystem() returning OT_UNIX.

Is there anywhere this will cause problems (i.e. where the other enum values are handled and OT_UNIX has been overlooked)?

[softins]

Note that this introduces for the first time the possibility of GetOperatingSystem() returning OT_UNIX.

Is there anywhere this will cause problems (i.e. where the other enum values are handled and OT_UNIX has been overlooked)?

No, the only places where the OT_xxx enum values are used are in GetOperatingSystem() and GetOperatingSystemString(). The value OT_UNIX is correctly accounted for in the latter, but that function is not called from anywhere in the codebase. Nothing else within Jamulus changes its behaviour depending on the OS value set here.