Add configurable monitoring for stale Dali store with critical operator alerts#168
Draft
Copilot wants to merge 3 commits into
Draft
Add configurable monitoring for stale Dali store with critical operator alerts#168Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
- Added storeNotSavedWarningPeriod config (default 72 hours) - Added minDeltaSizeWarningThreshold config (default 50MB) - Enhanced CLightCoalesceThread to check delta file size - Issue critical operator errors when both conditions are met - Provides early warning when sasha-coalescer may not be functioning Co-authored-by: jakesmith <902700+jakesmith@users.noreply.github.com>
- Mark dataPath member as const since it's never modified - Remove redundant 'CRITICAL:' prefix from error message Co-authored-by: jakesmith <902700+jakesmith@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add detection for stale store file and critical error handling
Add configurable monitoring for stale Dali store with critical operator alerts
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dali's main store file can go unsaved indefinitely when sasha-coalescer fails, causing unbounded delta file growth. Added monitoring to detect this condition and issue critical operator errors.
Configuration
Two new Dali attributes in
dali.xsd:storeNotSavedWarningPeriod(default: 72 hours) - time thresholdminDeltaSizeWarningThreshold(default: 50000 KB) - delta size thresholdMonitoring Logic
Enhanced
CLightCoalesceThreadto check delta file size when time threshold exceeded:Behavior
MCoperatorErrorwith detailed diagnostic messageOERRLOGwith delta size info (backward compatible)Prevents alert fatigue while ensuring operators are notified of genuine sasha-coalescer failures before delta files consume excessive disk space.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.