Skip to content

Add guide for scikit-learn#31

Merged
rsiyer-intel merged 4 commits into
intel:mainfrom
david-cortes-intel:sklearn
Jun 8, 2026
Merged

Add guide for scikit-learn#31
rsiyer-intel merged 4 commits into
intel:mainfrom
david-cortes-intel:sklearn

Conversation

@david-cortes-intel

Copy link
Copy Markdown
Contributor

Adds an entry for scikit-learn workflows.

CC @napetrov @avolkov-intel @Vika-F @razdoburdin for review.

@rsiyer-intel rsiyer-intel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thanks for the content!
Please consider adding a table of contents on the top with links to the sections and subsections. Similar to this document -
https://github.com/intel/optimization-zone/blob/main/software/kafka/README.md

Consider breaking the parallelism section into sub sections.
Also, make sure headings are nested correctly based on content hierarchy.

Also, please correct the following typos -
inerence → inference
README.md:3

pakage → package
README.md:25

duplicated word: that that
README.md:371

apriori → a priori
README.md:391

Ofentimes → Oftentimes
README.md:411

continuosly → continuously
README.md:411

preferrable → preferable
README.md:432

akind → akin
README.md:439

preferrable → preferable
README.md:457

@david-cortes-intel

Copy link
Copy Markdown
Contributor Author

Added a table of contents and fixed the typos.

Consider breaking the parallelism section into sub sections.

Please suggest a logical breakdown if you find the current one is not appropriate.

@rsiyer-intel rsiyer-intel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@adgubrud adgubrud self-requested a review June 4, 2026 18:07

@adgubrud adgubrud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsiyer-intel

Copy link
Copy Markdown
Collaborator

@david-cortes-intel Do you still need to get it reviewed with the folks you have CCed above? When they are done, I can merge it.

@david-cortes-intel

Copy link
Copy Markdown
Contributor Author

@david-cortes-intel Do you still need to get it reviewed with the folks you have CCed above? When they are done, I can merge it.

No, review is not needed. Can be merged now.

@rsiyer-intel rsiyer-intel merged commit 10b2d87 into intel:main Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants