Skip to content

refactor: refactoring framework #382

Draft
medcl wants to merge 137 commits into
mainfrom
console_framework
Draft

refactor: refactoring framework #382
medcl wants to merge 137 commits into
mainfrom
console_framework

Conversation

@medcl

@medcl medcl commented Jun 11, 2026

Copy link
Copy Markdown
Member

UserSessionInfo.Permissions was removed but modules/security/account/refresh.go still referenced it, causing compilation failures.

Changes

  • Removed direct Permissions field usage in refreshSessionUser and cloneSessionUser
  • Replaced with NewUserAssignedPermission(GetAllPermissionsForUser(sessionUser), nil) — the same pattern used in access_token/authentication.go and core/security/cache.go
sessionUser.UserAssignedPermission = security.NewUserAssignedPermission(
    security.GetAllPermissionsForUser(sessionUser), nil,
)

hardy-dev-infinilabs and others added 30 commits May 6, 2026 17:18
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved all merge conflicts. Here's a summary of how each was handled:

  • core/config/system.go: Used main's updated AccessTokenConfig with Enabled bool and Native bool fields (replacing the old Native RealmConfig field).
  • core/pipeline/context.go: Kept this branch's new GetResultState() and GetResultError() methods while adopting main's updated comment on Pause().
  • core/security/run_as.go: Applied main's spacing fix.
  • core/security/session.go: Kept the sync import (required for sync.Map used for sessionTokenResponseDecorators).
  • core/security/validate.go: Used main's refactored ordered-slice approach for auth filter iteration.
  • docs/release-notes/_index.md: Merged both branches' changelog entries.
  • go.mod / go.sum: Removed unused google.golang.org/grpc, added github.com/tetratelabs/wazero from main.
  • lib/cache/cache_test.go / layeredcache_test.go: Used main's GreaterOrEqual assertions (more robust under timing variance).
  • modules/configs/common/token.go: Kept the file — it's still referenced by modules/configs/client/client.go and core/api/basic_auth.go.
  • modules/pipeline/model.go: Kept this branch's richer PipelineStatus struct (adds LastRunState and Result fields used by the task status API).
  • modules/pipeline/pipeline.go: Used main's ORM-backed CRUD handlers (create/get/update/delete/search pipelines persisted via ORM).
  • modules/pipeline/tasks.go: Kept this branch's enriched PipelineStatus return (includes LastRunState and Result).
  • modules/security/native/ files: Fixed package declarations from rbacnative (the directory was renamed in main).

Copilot finished work on behalf of medcl June 11, 2026 06:29
hardy-dev-infinilabs and others added 2 commits June 11, 2026 14:35
…lias

GetPipelineTasksResponse should be an alias of GetPipelinesResponse, not the other way around. The primary type GetPipelinesResponse is the concrete map type.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI changed the title Console framework fix: remove references to deleted Permissions field in UserSessionInfo Jun 11, 2026
Copilot finished work on behalf of medcl June 11, 2026 09:29
@medcl medcl changed the title fix: remove references to deleted Permissions field in UserSessionInfo refactor: refactoring framework Jun 11, 2026
@medcl medcl marked this pull request as draft June 16, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants