transpile: Include enums in CastKind::from_types#1737
Open
Rua wants to merge 2 commits intoimmunant:masterfrom
Open
transpile: Include enums in CastKind::from_types#1737Rua wants to merge 2 commits intoimmunant:masterfrom
CastKind::from_types#1737Rua wants to merge 2 commits intoimmunant:masterfrom
Conversation
fw-immunant
reviewed
Apr 15, 2026
Contributor
fw-immunant
left a comment
fw-immunant
left a comment
There was a problem hiding this comment.
The code changes look plausible, but the practical impact of this change isn't clear to me. Does this impact generated code or enable accepting more input programs? It would be nice to have a test demonstrating changed behavior.
Contributor
Author
fw-immunant
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wasn't catching enum types yet, so they'd end up defaulting to
BitCast.