transpile: Use raw borrows in assembly translations#1716
transpile: Use raw borrows in assembly translations#1716Rua wants to merge 2 commits intoimmunant:kkysen/transpile-snapshots-expect_unresolved_importfrom
Conversation
e9c40a8 to
4bb0ddf
Compare
kkysen
left a comment
There was a problem hiding this comment.
Since this depends on the changes made to asm-casts in #1712, I don't know if this will work as-is or if other changes are needed. It doesn't seem like the asm-casts crate is available for snapshot tests in any case?
No, not yet. The snapshot tests run rustc directly, not cargo, so resolving other dependencies is annoyingly difficult. We skip running rustc on tests containing libc, for example.
|
It doesn't seem to have any trouble with tests that require |
Hmm, that's weird. Are those tests using |
|
I guess for now, I can mark these as "expect compile error"? EDIT: I've now done so, but it's a rather bad hack/workaround... |
See #1716. It's still a workaround, as switching to |
Since this depends on the changes made to asm-casts in #1712, I don't know if this will work as-is or if other changes are needed. It doesn't seem like the asm-casts crate is available for snapshot tests in any case?