Skip to content

feature: db:migrate:reset:with_data#161

Open
schwern wants to merge 1 commit into
ilyakatz:mainfrom
emailintegrations:feature/db-migrate-reset-with_data
Open

feature: db:migrate:reset:with_data#161
schwern wants to merge 1 commit into
ilyakatz:mainfrom
emailintegrations:feature/db-migrate-reset-with_data

Conversation

@schwern

@schwern schwern commented Dec 15, 2020

Copy link
Copy Markdown

Usually when resetting a database there is no data, but we use data migrations to create table partitions so we need to make sure they run even in development. (Having them as schema migrations adds spurious changes to the schema every month).

Usually when resetting a database there is no data, but we use data migrations
to create table partitions so we need to make sure they run. (Having them as
schema migrations adds spurious changes to the schema every month).
@schwern schwern force-pushed the feature/db-migrate-reset-with_data branch from b7c04de to 444d5a7 Compare December 15, 2020 22:36
@schwern

schwern commented Dec 22, 2020

Copy link
Copy Markdown
Author

This also ensures the data migration table isn't removed from the schema by rails db:migrate:reset.

@ilyakatz

Copy link
Copy Markdown
Owner

hm, don't know how I missed this one, this was a long time ago but seems like a simple change. do people still think this is useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants