Gate deploy on CI checks and fix all checks#38
Merged
Conversation
Workflows: - deploy.yml now runs the full check suite (via checks.yml workflow_call) before build/deploy, so a red commit never ships -- including direct pushes to develop. Removed the duplicate main.yml and consolidated onto a single reusable checks.yml. PR checks use pull_request with a throwaway test SECRET_KEY instead of pull_request_target with the production key. Formatting: - Reformat 35 files with Black (24.1.0) and 2 JS files with Prettier. Backend tests (were 120 failing, identical on develop): - Realign stale shared/form fixtures to the current Application model (drop removed what_hackathon_experience, fix field names, add required fields). - ApplicationForm.clean() uses .get() so a missing field is a validation error rather than a 500. - Override the hardware sign-out window in date-dependent order tests and complete OrderSubmissionWithLockTestCase (team/user2/helper). - Update hardware serializer/response expectations (credits, total_credits, packing_admin, hardware_name). - Use the Submitted -> In Progress order status transition. - Widen the phone-number validator to accept formatted numbers and reject overly long ones. - Align accepted/waitlisted email tests to the current templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflows:
Formatting:
Backend tests (were 120 failing, identical on develop):
Overview
Unit Tests Created
Steps to QA