Skip to content

Commit b98a560

Browse files
committed
Merge pull request #33 from iromli/develop
Move error message from form element placeholder
2 parents 9465c2c + 71b0355 commit b98a560

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

users/static/js/user-map.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -337,18 +337,21 @@ function validate_user_form(str_name, str_email, str_website) {
337337
is_all_valid = is_name_valid && is_email_valid && is_website_valid;
338338
if (!is_name_valid) {
339339
var $name_input = $('#name');
340+
var $name_err = $('#name-error');
340341
$name_input.parent().addClass('has-error');
341-
$name_input.attr('placeholder', 'Name is required');
342+
$name_err.text('Name is required');
342343
}
343344
if (!is_email_valid) {
344345
var $email_input = $('#email');
346+
var $email_err = $('#email-error');
345347
$email_input.parent().addClass('has-error');
346-
$email_input.attr('placeholder', 'Email is required and needs to be valid email');
348+
$email_err.text('Email is required and needs to be valid email');
347349
}
348350
if (!is_website_valid) {
349351
var $website_input =$("#website");
352+
var $website_err =$("#website-error");
350353
$website_input.parent().addClass('has-error');
351-
$website_input.attr('placeholder', 'Website needs to be a valid URL');
354+
$website_err.text('Website needs to be a valid URL');
352355
}
353356
return is_all_valid;
354357
}

users/templates/html/user_form.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ <h3 class="panel-title">User Data</h3>
1111
<input type="text" class="form-control" placeholder="Required"
1212
id="name" name="name" required value=""/>
1313
</div>
14+
<span class="help-inline" id="name-error"></span>
1415
</div>
1516

1617
<div class="form-group">
@@ -19,6 +20,7 @@ <h3 class="panel-title">User Data</h3>
1920
<input type="email" class="form-control" placeholder="Required"
2021
id="email" name="email" value="" required />
2122
</div>
23+
<span class="help-inline" id="email-error"></span>
2224
</div>
2325

2426
<div class="form-group">
@@ -28,6 +30,7 @@ <h3 class="panel-title">User Data</h3>
2830
placeholder="If filled, use http:// or https://."
2931
id="website" name="website" pattern="https?://.+" value=""/>
3032
</div>
33+
<span class="help-inline" id="website-error"></span>
3134
</div>
3235

3336
<div class="form-group">

0 commit comments

Comments
 (0)