Skip to content

Commit 71b0355

Browse files
committed
Merge branch 'develop' of git://github.com/id-python/members into develop
2 parents 743b530 + 5c9fbf7 commit 71b0355

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

users/__init__.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@
1414
from users.database import db, migrate
1515

1616

17+
APP = Flask(__name__)
18+
# Load configuration from any possible means.
19+
AppConfig(APP, default_settings="users.default_config")
20+
21+
1722
def add_handler_once(logger, handler):
1823
"""A helper to add a handler to a logger, ensuring there are no duplicates.
1924
@@ -45,12 +50,12 @@ def setup_logger():
4550
# create formatter that will be added to the handlers
4651
formatter = logging.Formatter(
4752
'%(asctime)s - %(name)s - %(levelname)s - %(message)s')
48-
temp_dir = '/tmp'
53+
log_dir = APP.config['LOG_DIR']
4954
# so e.g. jenkins can override log dir.
5055
if 'USER_MAP_LOGFILE' in os.environ:
5156
file_name = os.environ['USER_MAP_LOGFILE']
5257
else:
53-
file_name = os.path.join(temp_dir, 'user-map.log')
58+
file_name = os.path.join(log_dir, 'user-map.log')
5459
file_handler = logging.FileHandler(file_name)
5560
file_handler.setLevel(handler_level)
5661
# create console handler with a higher log level
@@ -68,10 +73,6 @@ def setup_logger():
6873
setup_logger()
6974
LOGGER = logging.getLogger('user_map')
7075

71-
APP = Flask(__name__)
72-
73-
# Load configuration from any possible means.
74-
AppConfig(APP, default_settings="users.default_config")
7576

7677
# Mailer
7778
mail = Mail(APP)

users/default_config.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@
4848
shadow='/static/img/marker-shadow.png'
4949
)
5050

51+
# Directory location for log file
52+
LOG_DIR = '/tmp'
53+
5154
# By default it uses postgres, hence you'll need to ``psycopg2``.
5255
# If you're using MySQL, refer to
5356
# http://docs.sqlalchemy.org/en/rel_0_9/core/engines.html

0 commit comments

Comments
 (0)