[minor] Create functions to fetch cluster issuer#161
Merged
Conversation
durera
requested changes
Feb 18, 2026
durera
left a comment
durera
left a comment
Contributor
There was a problem hiding this comment.
Can we also add unittests for the new function to the tests. Don't need you to fill existing test gaps, but we don't want to create more gaps going forward. Use mock framework, and include good/bad path test scenarios.
Also note that delivery is tied to ibm-mas/cli#1983 (review)
We need to update the CLI PR to include the RBAC additions for the new capability that will be used by the CLI user:
https://github.com/ibm-mas/cli/tree/master/rbac/install/user .. the clusterrole will need to be updated to provide the necessary access for the ClusterIssuer resource before this pair of PRs can be merged
durera
approved these changes
Jun 4, 2026
durera
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getClusterIssuerandgetClusterIssuersto support [minor] Support BYO ClusterIssuer cli#1983.