[patch] add cluster mode support for gitops#481
Merged
Merged
Conversation
whitfiea
requested changes
Jun 8, 2026
| @@ -0,0 +1,34 @@ | |||
| {{- if .Values.application_admin_role }} | |||
Member
There was a problem hiding this comment.
this should be cluster_admin_role. gitops has a concept of cluster and application (akla namespaced) modes already for its resources. As this is creating cluster level resources then it needs to be cluster_admin_role (the same for the job in the other file as well.
whitfiea
previously approved these changes
Jun 8, 2026
Member
|
Needs a new cli release with ibm-mas/python-devops#376 in before merging |
mnivedithaa
approved these changes
Jun 15, 2026
sumitjain-1901
pushed a commit
that referenced
this pull request
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira Issue
Guidance for Reviewers
[minor] add pre-install rbac for saas python-devops#376
Testing