Skip to content

[minor] Added support for FACILITIES.properties in Facilities#2313

Merged
sanjayprab merged 25 commits into
masterfrom
masref-5152
Jun 3, 2026
Merged

[minor] Added support for FACILITIES.properties in Facilities#2313
sanjayprab merged 25 commits into
masterfrom
masref-5152

Conversation

@sdoshi96

@sdoshi96 sdoshi96 commented May 26, 2026

Copy link
Copy Markdown
Contributor

1. Description

  • Added interactive prompt asking users if they want to upload a custom FACILITIES.properties file
  • Added optional Tekton workspace shared-facilities-properties to pipeline and facilities workspace to mas-devops-suite-app-install task
  • Added 3 new pipeline parameters: mas_ws_facilities_custom_properties, mas_ws_facilities_properties_file_local, and mas_ws_facilities_properties_secret_name
  • Implemented the file validation in both interactive and non-interactive modes

2. Issues

3. Dependencies

4. Tests

3.1. CLI Help

image image image

3.2. Deploy on the QB cluster using CLI

image

Screenshot of the created secret in the pipelines namespace:
image

Screenshot of the Facilities Install Task where workspace is bound to the created secret and its usage in the logs:
image

image image

⚠️ Notes for Reviewers

  • Ensure you have understood the PR guidelines in the Playbook before proceeding with a review.
  • Ensure all sections in the PR template are appropriately completed.

@sdoshi96 sdoshi96 marked this pull request as ready for review June 1, 2026 15:27
@sdoshi96 sdoshi96 requested a review from a team as a code owner June 1, 2026 15:27
@sanjayprab sanjayprab changed the title [patch] Added support for FACILITIES.properties in Facilities [minor] Added support for FACILITIES.properties in Facilities Jun 3, 2026
Comment thread python/src/mas/cli/install/app.py
@sanjayprab sanjayprab merged commit 5263b16 into master Jun 3, 2026
14 checks passed
@sanjayprab sanjayprab deleted the masref-5152 branch June 3, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants