IBX-11949: Added is_not_translatable form variable support to form_ro…#1952
Open
mikadamczyk wants to merge 1 commit into
Open
IBX-11949: Added is_not_translatable form variable support to form_ro…#1952mikadamczyk wants to merge 1 commit into
mikadamczyk wants to merge 1 commit into
Conversation
…w_fieldtype block
mikadamczyk
force-pushed
the
IBX-11949-non-translatable-in-field
branch
from
d5204e6 to
2b82648
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The
form_row_fieldtypeblock hardcodes howfieldtype_is_not_translatableis determined, making it impossible for external packages to override this value. This change checks for ais_not_translatableform variable first, falling back to the existing logic when it's not set. This is needed so that the side-by-side translation view inibexa/translations-managementcan signal to the field template that a field should display the non-translatable message inside the field wrapper, achieving proper visual alignment with the target form column.For QA:
Documentation: