IBX-11909: new main menu design#1944
Open
tischsoic wants to merge 12 commits into
Open
Conversation
tischsoic
commented
Jun 23, 2026
|
|
||
| for (const tooltipNode of tooltipsNode) { | ||
| bootstrap.Tooltip.getOrCreateInstance(tooltipNode).hide(); | ||
| const tooltipInstance = bootstrap.Tooltip.getInstance(tooltipNode); |
Contributor
Author
There was a problem hiding this comment.
Note: fix needed to avoid creating tooltip instances when hiding tooltips, which circumvent our parse function's custom logic.
|
ibexa-workflow-automation-1
Bot
requested review from
GrabowskiM,
OstafinL,
albozek,
alekmick and
dew326
and removed request for
a team
GrabowskiM
reviewed
Jun 23, 2026
Comment on lines
+50
to
+52
| padding: 1px 0; | ||
| margin-left: 12px; | ||
| margin-top: 8px; |
Contributor
There was a problem hiding this comment.
Suggested change
| padding: 1px 0; | |
| margin-left: 12px; | |
| margin-top: 8px; | |
| padding: calculateRem(1px) 0; | |
| margin-left: calculateRem(12px); | |
| margin-top: calculateRem(8px); |
albozek
reviewed
Jun 25, 2026
| display: flex; | ||
| flex-direction: column; | ||
| width: calculateRem(264px); | ||
|
|
Comment on lines
+186
to
+188
| margin-top: 8px; | ||
| margin-left: 10px; | ||
| padding: 1px 0; |
Contributor
There was a problem hiding this comment.
Suggested change
| margin-top: 8px; | |
| margin-left: 10px; | |
| padding: 1px 0; | |
| margin-top: calculateRem(8px); | |
| margin-left: calculateRem(10px); | |
| padding: calculateRem(1px) 0; |
| overflow: hidden; | ||
|
|
||
| > .ibexa-main-menu__items-list { | ||
| margin-left: 28px; |
Contributor
There was a problem hiding this comment.
Suggested change
| margin-left: 28px; | |
| margin-left: calculateRem(28)px; |
| } %} | ||
|
|
||
| <a {{ knp_menu.attributes(link_attributes) }}>{{ block('label') }}</a> | ||
| <a {{ knp_menu.attributes(link_attributes) }}>!!{{ block('label') }}</a> |
Contributor
There was a problem hiding this comment.
Suggested change
| <a {{ knp_menu.attributes(link_attributes) }}>!!{{ block('label') }}</a> | |
| <a {{ knp_menu.attributes(link_attributes) }}>{{ block('label') }}</a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: