Skip to content

OSD custom elements: add 16-bit icon support#11608

Open
error414 wants to merge 1 commit into
iNavFlight:maintenance-10.xfrom
error414:error414/feature/16bits-icons
Open

OSD custom elements: add 16-bit icon support#11608
error414 wants to merge 1 commit into
iNavFlight:maintenance-10.xfrom
error414:error414/feature/16bits-icons

Conversation

@error414
Copy link
Copy Markdown
Contributor

CUSTOM_ELEMENT_TYPE_ICON_GV and CUSTOM_ELEMENT_TYPE_ICON_LC were hard-casting the resolved icon value to uint8_t, limiting icons to 0–255. This change lifts that restriction to match the existing 16-bit handling already present in CUSTOM_ELEMENT_TYPE_ICON_STATIC.

image

Configurator PR: iNavFlight/inav-configurator#2643

@qodo-code-review
Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@github-actions
Copy link
Copy Markdown

Test firmware build ready — commit b200445

Download firmware for PR #11608

237 targets built. Find your board's .hex file by name on that page (e.g. MATEKF405SE.hex). Files are individually downloadable — no GitHub login required.

Development build for testing only. Use Full Chip Erase when flashing.

@Jetrell
Copy link
Copy Markdown

Jetrell commented May 31, 2026

@error414 Sorry for the false report in the configurator side. I stupidly didn't load the fw side with it..
I checked it again. And I'm happy to say you got it to work. Very nice.

@error414
Copy link
Copy Markdown
Contributor Author

error414 commented Jun 1, 2026

@Jetrell it's ok :). thank you very much for test.

I knew about that restriction from the begining, it was on my list for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants