Skip to content

dshot beeper ignore list fix#11604

Merged
sensei-hacker merged 1 commit into
iNavFlight:masterfrom
P-I-Engineer:dshot-beeper-buzzer-ignore-fix
May 30, 2026
Merged

dshot beeper ignore list fix#11604
sensei-hacker merged 1 commit into
iNavFlight:masterfrom
P-I-Engineer:dshot-beeper-buzzer-ignore-fix

Conversation

@P-I-Engineer
Copy link
Copy Markdown
Contributor

dshot beeper was implemented outside of the beeper ignore list.

it's been added in now along with a beeper off.

@qodo-code-review
Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@github-actions
Copy link
Copy Markdown

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@sensei-hacker
Copy link
Copy Markdown
Member

sensei-hacker commented May 30, 2026

This may sound like a silly question, but has this been tested with it NOT set?
Often, we test that code does what we want it to do, but forget to test that it doesn't do what we don't want it to do. :). Ie doesn't stop the beeper from working when it's supposed to.

@P-I-Engineer
Copy link
Copy Markdown
Contributor Author

yes:
tested with beeper list empty, the motor beeped and buzzer beeped on hw_failure.
then tested with "beeper -hw_failure" and neither motor or buzzer beeped.

i tested in steps on purpose.

@sensei-hacker sensei-hacker merged commit c497d4f into iNavFlight:master May 30, 2026
24 checks passed
@sensei-hacker
Copy link
Copy Markdown
Member

Oops, the branch wasn't updated so any release, so this would never end up getting released. I'll cherry-pick it into 9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants