⚡ Bolt: Cache icon lookups to improve render performance#43
Conversation
Caches the `iconData` results in `IconifyIcon.tsx` inside a Map to prevent repeating O(N) fallback lookups on subsequent renders for the same icon string. Co-authored-by: sshahriazz <34005640+sshahriazz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added a memory cache (
Map) toclient/src/components/base/IconifyIcon.tsxto memoize the resolution oficonDataobjects from string identifiers.🎯 Why: Previously, if an icon was prefix-less (e.g. just
homerather thanic:baseline-home),getIconData()iterated overObject.entries(iconSets)(up to 11 dictionaries) on every single render of the component. Dashboard apps routinely render 100s of icons in Sidebars and DataGrids, leading to significant CPU overhead and decreased main thread availability during initial loads and heavy re-renders.📊 Impact: Reduces redundant lookup array iterations from O(N) to an O(1) dictionary lookup on cache hits, yielding massive improvements to render times for pages heavily utilizing icons.
🔬 Measurement: Render time via React Profiler when loading pages like
/accountwith 50+ sidebar and panel icons should demonstrate decreased component compute time.Additionally logged this codebase-specific anti-pattern in
.jules/bolt.md.PR created automatically by Jules for task 6889459595122681135 started by @sshahriazz