fix: copy-paste bugs, select case order, and safety checks#2
Merged
Conversation
Fix incorrect godoc method names in sdk.go, reorder select cases in quote.go to match the standard pattern used everywhere else, replace defer-in-loop with immediate cancel in trade_test.go, add nil guard to SecurityToCode, and stop silently discarding ToProto errors in NewCustomIndicatorFilter and NewFilterConditions. 💘 Generated with Crush Assisted-by: Crush:mimo-v2.5-pro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdk.go: Fixed two incorrect godoc comments —GetOrderList→GetMaxTrdQtysandGetHistoryOrderList→GetOrderFillList(copy-paste errors from adjacent methods)client/quote.go: Reorderedselectcases inQotGetMarketStateandQotGetOptionExpirationDateto match the standard<-ctx.Done()/<-client.closed/<-chpattern used in every other functionclient/trade_test.go: Replaceddefer cancel()with immediatecancel()call inside aforloop —deferis function-scoped, so cancel functions were accumulating until function exitadapt/adapt.go: Added nil guard toSecurityToCodeto prevent nil pointer panic; changedNewCustomIndicatorFilterandNewFilterConditionsto returnnilonToProtoerror instead of silently discarding itTest plan
go vet ./...passesgo test ./adapt/... ./infra/...passesgo test ./...) require live FutuOpenD instance💘 Generated with Crush