Batch remote bitfield index refreshes#808
Open
marcus-pousette-hp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Receiving a multi-page remote bitfield currently refreshes the sparse quickbit index once per 4 KiB page. For a full 2 MiB segment, that rebuilds the same segment index 64 times.
This changes
RemoteBitfield.insert()to copy all touched pages first and refresh each touched segment once. It also updatesclear()to keep the sparse index correct forfirstUnset()by updating the affected 128-bit quickbit index chunks.Local microbench, 100 repeated inserts of the same remote bitfield:
The full-segment case improves by roughly 60x because it now rebuilds the sparse quickbit index once per touched segment instead of once per 4 KiB page.
PR as co-written with AI