Fix shatter memory DoS by writing per-leaf results#153
Closed
ClayWarren wants to merge 2 commits intohobuinc:mainfrom
Closed
Fix shatter memory DoS by writing per-leaf results#153ClayWarren wants to merge 2 commits intohobuinc:mainfrom
ClayWarren wants to merge 2 commits intohobuinc:mainfrom
Conversation
…ity-in-shatter Fix shatter memory DoS by writing per-leaf results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
do_one()to return full per-leafDataFrames andrun()to accumulate them injoined_dfsandpd.concat, allowing unbounded memory growth for large/adversarial inputs.Description
src/silvimetric/commands/shatter.pysodo_one()now returns anintpoint count and writes each leaf immediately instead of returning aDataFrame.do_one()now sorts the per-leaf joined data by['xi','yi']and callswrite(...)to persist the leaf and return the written point count, and returns0for skipped/empty leaves.run()no longer accumulatesDataFrames; it aggregates per-leaf point counts viapoint_countfrom Dask futures orcompute(...)results and updatesconfig.point_countaccordingly.pd.concat(joined_dfs)path to eliminate unbounded in-memory aggregation while preserving deterministic per-leaf ordering.Testing
python -m compileall src/silvimetric/commands/shatter.pywhich succeeded and verified the modified file compiles.