Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw #34 and decided the proper fix was to update the CMake configuration to use
CONFIGfind_packageusage, so I asked Codex to do all this stuff instead.Updates from Codex
Modernized the top-level CMake configuration in
CMakeLists.txt.cmake_minimum_requiredto3.16...4.3to remove current deprecation warnings.CMAKE_FIND_PACKAGE_PREFER_CONFIG.WITH_TESTSoption and gatedenable_testing()andadd_subdirectory(test)behind it.find_package(GDAL CONFIG REQUIRED)andGDAL::GDAL.1.9.0or newer.Updated the test build in
test/CMakeLists.txt.FetchContent.GTest::gtestandGDAL::GDAL.$<TARGET_FILE:...>.Removed the vendored GoogleTest source tree under
test/gtest/.Updated the local build helper script in
hobu.sh.set -euo pipefail.hexerconda environment.WITH_TESTS=ON.Documented the example build flow in
README.md.Buildingsection.conda run -n hexer ./hobu.sh.Added GitHub Actions CI in
.github/workflows/ci.yml.cmake,ninja, andgdal.