Remove makeup_syntect#154
Merged
Merged
Conversation
makeup_syntect highlights via a Rust NIF that cannot be interrupted by the surrounding Task timeout. A single crafted file (e.g. deeply-nested JSON) made the NIF allocate gigabytes before returning, OOM-ing the pod, with neither the file-size cap nor the timeout able to bound it. The remaining makeup lexers (Elixir, Erlang, EEx, Gleam) are pure Elixir and run as ordinary BEAM processes, so the existing highlight timeout can actually kill them. Files in formats only syntect covered now render as plain text.
ericmj
force-pushed
the
remove-makeup-syntect
branch
from
f18673f to
d974806
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makeup_syntect highlights via a Rust NIF that cannot be interrupted by the surrounding Task timeout. A single crafted file (e.g. deeply-nested JSON) made the NIF allocate gigabytes before returning, OOM-ing the pod, with neither the file-size cap nor the timeout able to bound it.
The remaining makeup lexers (Elixir, Erlang, EEx, Gleam) are pure Elixir and run as ordinary BEAM processes, so the existing highlight timeout can actually kill them. Files in formats only syntect covered now render as plain text.