Stop retrying a failed token refresh on every request#199
Merged
Conversation
When a global OAuth token is expired and its refresh is rejected by the server, the refresh was re-attempted on the next request: a failed refresh changed no state, so each caller serialized behind the token-refresh lock re-read the same expired token and re-POSTed to /oauth/token. Resolving over N packages produced N failed refreshes. Add an optional clear_oauth_tokens callback. On a failed refresh, do_resolve_oauth_token_with_context invokes it while holding the token-refresh lock so the build tool can invalidate the unusable token; callers behind the lock then re-read it as absent and fall back to unauthenticated instead of retrying. The refresh is attempted at most once per run. The callback is optional, so existing callers keep working unchanged.
maennchen
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a global OAuth token is expired and its refresh is rejected by the server, the refresh was re-attempted on the next request: a failed refresh changed no state, so each caller serialized behind the token-refresh lock re-read the same expired token and re-POSTed to /oauth/token. Resolving over N packages produced N failed refreshes.
Add an optional clear_oauth_tokens callback. On a failed refresh, do_resolve_oauth_token_with_context invokes it while holding the token-refresh lock so the build tool can invalidate the unusable token; callers behind the lock then re-read it as absent and fall back to unauthenticated instead of retrying. The refresh is attempted at most once per run. The callback is optional, so existing callers keep working unchanged.