Skip to content

feat(network): support packet capture file creation#2275

Merged
mkroening merged 1 commit intohermit-os:mainfrom
cagatay-y:feat-pcap
Apr 13, 2026
Merged

feat(network): support packet capture file creation#2275
mkroening merged 1 commit intohermit-os:mainfrom
cagatay-y:feat-pcap

Conversation

@cagatay-y
Copy link
Copy Markdown
Contributor

@cagatay-y cagatay-y commented Feb 20, 2026

Allows creating packet capture files in the pcap format.

The feature also allows us to get nice graphs by using Wireshark's built-in tools.
1771604408

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 33e76ad Previous: 24c4663 Performance Ratio
startup_benchmark Build Time 90.09 s 88.24 s 1.02
startup_benchmark File Size 0.79 MB 0.79 MB 1.00
Startup Time - 1 core 0.80 s (±0.03 s) 0.79 s (±0.03 s) 1.01
Startup Time - 2 cores 0.81 s (±0.02 s) 0.81 s (±0.03 s) 1.00
Startup Time - 4 cores 0.82 s (±0.03 s) 0.81 s (±0.03 s) 1.01
multithreaded_benchmark Build Time 87.87 s 90.76 s 0.97
multithreaded_benchmark File Size 0.89 MB 0.89 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 92.16 % (±7.16 %) 87.89 % (±6.87 %) 1.05
Multithreaded Pi Efficiency - 4 Threads 46.18 % (±4.48 %) 43.72 % (±3.46 %) 1.06
Multithreaded Pi Efficiency - 8 Threads 26.50 % (±2.55 %) 25.77 % (±2.27 %) 1.03
micro_benchmarks Build Time 97.43 s 99.39 s 0.98
micro_benchmarks File Size 0.90 MB 0.90 MB 1.00
Scheduling time - 1 thread 71.26 ticks (±5.05 ticks) 70.93 ticks (±4.00 ticks) 1.00
Scheduling time - 2 threads 40.27 ticks (±5.75 ticks) 39.29 ticks (±5.29 ticks) 1.02
Micro - Time for syscall (getpid) 3.03 ticks (±0.42 ticks) 3.05 ticks (±0.29 ticks) 0.99
Memcpy speed - (built_in) block size 4096 80486.21 MByte/s (±55685.05 MByte/s) 75684.65 MByte/s (±52306.72 MByte/s) 1.06
Memcpy speed - (built_in) block size 1048576 30409.59 MByte/s (±24859.56 MByte/s) 30355.04 MByte/s (±24824.82 MByte/s) 1.00
Memcpy speed - (built_in) block size 16777216 25544.16 MByte/s (±21335.35 MByte/s) 24877.02 MByte/s (±20808.46 MByte/s) 1.03
Memset speed - (built_in) block size 4096 80785.34 MByte/s (±55895.17 MByte/s) 75489.41 MByte/s (±52157.36 MByte/s) 1.07
Memset speed - (built_in) block size 1048576 31153.79 MByte/s (±25288.58 MByte/s) 31104.32 MByte/s (±25249.22 MByte/s) 1.00
Memset speed - (built_in) block size 16777216 26322.27 MByte/s (±21835.12 MByte/s) 25648.60 MByte/s (±21318.72 MByte/s) 1.03
Memcpy speed - (rust) block size 4096 69832.51 MByte/s (±48678.47 MByte/s) 68541.24 MByte/s (±48090.88 MByte/s) 1.02
Memcpy speed - (rust) block size 1048576 30239.85 MByte/s (±24915.76 MByte/s) 30123.18 MByte/s (±24800.90 MByte/s) 1.00
Memcpy speed - (rust) block size 16777216 25205.56 MByte/s (±21021.01 MByte/s) 25486.19 MByte/s (±21254.05 MByte/s) 0.99
Memset speed - (rust) block size 4096 70255.34 MByte/s (±49001.98 MByte/s) 68714.33 MByte/s (±48204.76 MByte/s) 1.02
Memset speed - (rust) block size 1048576 31002.04 MByte/s (±25351.11 MByte/s) 30861.15 MByte/s (±25218.52 MByte/s) 1.00
Memset speed - (rust) block size 16777216 25972.59 MByte/s (±21523.62 MByte/s) 26201.97 MByte/s (±21694.63 MByte/s) 0.99
alloc_benchmarks Build Time 92.22 s 91.34 s 1.01
alloc_benchmarks File Size 0.86 MB 0.86 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 6940.97 Ticks (±87.75 Ticks) 6656.51 Ticks (±88.73 Ticks) 1.04
Allocations - Average Allocation time (no fail) 6940.97 Ticks (±87.75 Ticks) 6656.51 Ticks (±88.73 Ticks) 1.04
Allocations - Average Deallocation time 861.07 Ticks (±233.44 Ticks) 1589.29 Ticks (±124.64 Ticks) 0.54
mutex_benchmark Build Time 90.95 s 91.58 s 0.99
mutex_benchmark File Size 0.90 MB 0.90 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 12.84 ns (±0.73 ns) 13.12 ns (±0.74 ns) 0.98
Mutex Stress Test Average Time per Iteration - 2 Threads 19.64 ns (±11.24 ns) 18.84 ns (±9.22 ns) 1.04

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening mkroening self-assigned this Feb 20, 2026
@cagatay-y cagatay-y force-pushed the feat-pcap branch 2 times, most recently from 5ab22eb to 9a29331 Compare February 25, 2026 16:41
Copy link
Copy Markdown
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread Cargo.toml Outdated
Comment thread src/executor/network.rs Outdated
Comment thread Cargo.toml Outdated
Comment thread src/executor/network.rs
Comment thread src/executor/device.rs Outdated
Comment thread src/executor/device.rs Outdated
Comment thread src/executor/device.rs Outdated
Comment thread Cargo.toml Outdated
@cagatay-y cagatay-y force-pushed the feat-pcap branch 4 times, most recently from 3298de6 to 5107172 Compare March 9, 2026 16:59
Copy link
Copy Markdown
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! :)

Comment thread src/executor/device.rs Outdated
Comment thread src/executor/device.rs Outdated
Comment thread src/executor/device.rs Outdated
Comment thread src/executor/device.rs Outdated
Comment thread src/executor/network.rs Outdated
Comment thread Cargo.toml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread src/executor/device.rs Outdated
Comment thread src/executor/device.rs
Comment thread src/executor/device.rs Outdated
@cagatay-y cagatay-y force-pushed the feat-pcap branch 2 times, most recently from f42e323 to a49e610 Compare April 11, 2026 21:01
Allows creating packet capture files in the pcap format.

Co-authored-by: Martin Kröning <mkroening@posteo.net>
Copy link
Copy Markdown
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@mkroening mkroening added this pull request to the merge queue Apr 13, 2026
Merged via the queue into hermit-os:main with commit 48edfd9 Apr 13, 2026
20 checks passed
@cagatay-y cagatay-y deleted the feat-pcap branch April 13, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants