[WIP] Movement Recorder UX Enhancement#145
Open
hello-vinitha wants to merge 10 commits intomasterfrom
Open
Conversation
Contributor
|
this passed the functions test... leaving PR open until those 3 additional tasks are completed |
…obot/stretch_web_teleop into feature/move_r_contained
…d functionality to cancel playback; handle canceled/failed/succeed playback states;
…s during playback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously movement recorder was a global setting. When enabled in the Customization mode, the movement recorder would appear as a widget between the header and the panels. This took up significant vertical space on smaller screens. In this feature enhancement, movement recorder appears in a panel below the control buttons in the default view and has additional functionality that allows the user to edit and filter through a list of recorded movements.
Testing procedure
Checkout the

feature/move_r_containedbranch and launch the interface. As the default layout has changed, you may need to runlocalStorage.clear()in the webpage console. Movement recorder should appear below the controls similar to below:Test the following behaviors:
TO DOs:
Before opening a pull request
From the top-level of this repository, run:
pre-commit run --all-filesTo merge
Squash & Merge