Feature/#126 disable buttons during homing#127
Conversation
|
the styling for disabled is "meh" for now... just wanted to get the logic down i'll test it tmrw morn on vy's robot |
|
@hello-binit PR is ready for review |
|
@hello-william Could you include screenshots of how the UI should look? |
for sure! the robot should be un-homed tmrw, so i'll grab screenshots of the UI before+after it's homed |
|
while buttons are disabled all hover+click events are also disabled |
|
@hello-william looks like the docs from #124 are included in this PR. Do you want to rebase to only include your changes in this PR? |
c70af73 to
f4c61b6
Compare
|
@hello-binit ah sry about that... should be g2g 🏄♂️ |
hello-robot-shehab
left a comment
There was a problem hiding this comment.
fyi, I tested:
- Restarted Stretch -> launched interface -> tried the buttons, they are disabled, as expected. They look the same as the screenshot above.
- Homed using the button in the interface -> the buttons are now enabled, and work as expected.
- Restarted the robot -> homed using stretch_robot_home.py -> the robot is now homed -> launched the interface -> the buttons are enabled, as expected.
Code looks great. Thanks @hello-william!
hello-binit
left a comment
There was a problem hiding this comment.
Looks good to merge!
#45 actually solves this once it's merged to |




Description
Originally subtask in #60 but now moved to #126.
During homing, these buttonpads should be disabled:
Testing procedure
Before opening a pull request
From the top-level of this repository, run:
pre-commit run --all-filesTo merge
Squash & Merge