Skip to content

Feature/#126 disable buttons during homing#127

Merged
hello-binit merged 6 commits intomasterfrom
feature/#126-disable-buttons-during-homing
May 2, 2025
Merged

Feature/#126 disable buttons during homing#127
hello-binit merged 6 commits intomasterfrom
feature/#126-disable-buttons-during-homing

Conversation

@hello-william
Copy link
Copy Markdown
Contributor

@hello-william hello-william commented Apr 28, 2025

Description

Originally subtask in #60 but now moved to #126.

During homing, these buttonpads should be disabled:

ButtonPadButton.ArmLower
ButtonPadButton.ArmLift
ButtonPadButton.ArmExtend
ButtonPadButton.ArmRetract
ButtonPadButton.WristRotateIn
ButtonPadButton.WristRotateOut
ButtonPadButton.GripperOpen
ButtonPadButton.GripperClose

Testing procedure

  • Turn "on" robot and it still needs to be homed.
  • Ensure appropriate buttons are visually+functionally disabled.
  • Home it!
  • Ensure appropriate buttons have been enabled.

Before opening a pull request

From the top-level of this repository, run:

  • pre-commit run --all-files

To merge

  • Squash & Merge

@hello-william
Copy link
Copy Markdown
Contributor Author

the styling for disabled is "meh" for now... just wanted to get the logic down

i'll test it tmrw morn on vy's robot

@hello-william
Copy link
Copy Markdown
Contributor Author

@hello-binit PR is ready for review

@hello-binit
Copy link
Copy Markdown
Collaborator

@hello-william Could you include screenshots of how the UI should look?

@wle8300
Copy link
Copy Markdown
Contributor

wle8300 commented Apr 30, 2025

@hello-william Could you include screenshots of how the UI should look?

for sure!

the robot should be un-homed tmrw, so i'll grab screenshots of the UI before+after it's homed

@hello-william
Copy link
Copy Markdown
Contributor Author

@hello-binit

hasn't been homed...
iScreen Shoter - Brave Browser - 250430124048

...homing...
iScreen Shoter - Brave Browser - 250430124121

...homed!
iScreen Shoter - Brave Browser - 250430124141

while buttons are disabled all hover+click events are also disabled

@hello-binit
Copy link
Copy Markdown
Collaborator

@hello-william looks like the docs from #124 are included in this PR. Do you want to rebase to only include your changes in this PR?

@hello-william hello-william force-pushed the feature/#126-disable-buttons-during-homing branch from c70af73 to f4c61b6 Compare April 30, 2025 21:40
@hello-william
Copy link
Copy Markdown
Contributor Author

@hello-binit ah sry about that... should be g2g 🏄‍♂️

Copy link
Copy Markdown
Contributor

@hello-robot-shehab hello-robot-shehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, I tested:

  • Restarted Stretch -> launched interface -> tried the buttons, they are disabled, as expected. They look the same as the screenshot above.
  • Homed using the button in the interface -> the buttons are now enabled, and work as expected.
  • Restarted the robot -> homed using stretch_robot_home.py -> the robot is now homed -> launched the interface -> the buttons are enabled, as expected.

Code looks great. Thanks @hello-william!

Copy link
Copy Markdown
Collaborator

@hello-binit hello-binit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge!

@hello-binit
Copy link
Copy Markdown
Collaborator

I've seen this check fail with this error before. We'll need to look into it. For now, bypassing the check and merging.
image

@hello-binit hello-binit merged commit 6c6d9ba into master May 2, 2025
0 of 2 checks passed
@hello-binit hello-binit deleted the feature/#126-disable-buttons-during-homing branch May 2, 2025 15:20
@hello-william
Copy link
Copy Markdown
Contributor Author

@hello-binit

I've seen this check fail with this error before. We'll need to look into it. For now, bypassing the check and merging.

#45 actually solves this

once it's merged to master the pre-commit routine should go smoothly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants