This repository was archived by the owner on Oct 29, 2021. It is now read-only.
Have the validation keys as an IORef#193
Open
dnikolovv wants to merge 2 commits into
Open
Conversation
dnikolovv
commented
Jun 30, 2021
| -- | A @JWTSettings@ where the audience always matches. | ||
| defaultJWTSettings :: Jose.JWK -> JWTSettings | ||
| defaultJWTSettings k = JWTSettings | ||
| defaultJWTSettings :: Jose.JWK -> IO JWTSettings |
Author
There was a problem hiding this comment.
I was thinking we could even omit the IO via unsafePerformIO to avoid forcing existing users change their code. It should be relatively safe as the only thing we're doing is create a new IORef.
This will make the changes even less invasive (or in most cases invisible).
I guess @jkarni @domenkozar or other maintainers should give their opinion on that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This goes back to #153.
It is very limiting not being able to update the validation keys, as most auth providers (Cognito, Auth0, Firebase) use rotating keys.
This change makes it very straightforward to implement. I saw that there is a (stale?) PR referring to this issue (#169), but I find this approach much less invasive therefore I'm submitting a new one.
Example on how you could use this to implement rotating keys: