fix: prevent sequential Streamable HTTP clients from failing with Already connected to a transport#338
Open
AdaTest wants to merge 4 commits intohangwin:masterfrom
Open
fix: prevent sequential Streamable HTTP clients from failing with Already connected to a transport#338AdaTest wants to merge 4 commits intohangwin:masterfrom
AdaTest wants to merge 4 commits intohangwin:masterfrom
Conversation
Create a fresh MCP Server instance per transport so sequential HTTP/SSE clients do not hit the SDK's already-connected guard.
Keep each per-transport server lifecycle tied to its connection and clean it up when the transport is closed.
Replace the web-edited file with the clean local patch after verifying the editor document length.
Remove the singleton MCP server so each transport can connect to a fresh server instance.
AdaTest
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Serverfor each SSE/Streamable HTTP transport instead of reusing a singletonAlready connected to a transportVerification
pnpm --filter mcp-chrome-bridge lintpnpm --filter chrome-mcp-shared buildpnpm --filter mcp-chrome-bridge buildAlready connected to a transport