HCK-16464: Tables and view REed from the instance with limited number of columns and weird dummy text#348
Merged
Merged
Conversation
Nightlngale
changed the title
chulanovskyi-bs
approved these changes
Jun 19, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical details
The grammar contained two lexer rules for the same word DEFAULT:
Both matched the string DEFAULT, but ANTLR’s lexer always picks the first matching rule. As a result, the token stream contains DEFAULT only, never KW_DEFAULT.
Several parser rules still expected KW_DEFAULT (e.g. column DEFAULT constraints and GENERATED BY DEFAULT AS IDENTITY), which caused DDL parsing to fail during reverse engineering from instance.
I consolidated the grammar to use a single runtime token, DEFAULT, updated the affected parser rules, regenerated the ANTLR output, and adapted the visitor accordingly.
Also updated the logic of fetching views