Add timeout for wineserver wait in daemon stop#60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
stoppath could hang when invokingwineserver -w, causing the daemon stop command to block indefinitely.nettts-daemon.sh stopreliably returns even ifwineservermisbehaves.Description
WINESERVER_WAIT(fromNETTTS_WINESERVER_WAIT) with a default of5seconds and validate its value.wait_for_wineserver()which preferstimeoutif available and otherwise runswineserver -win a background waiter loop with a manual timeout and warnings.wineserver -winvocation instop_daemon()with the newwait_for_wineserver()helper.NETTTS_WINESERVER_WAITis invalid or when the wait times out.Testing
Codex Task