Add basic filtering support#243
Draft
martinling wants to merge 15 commits intogreatscottgadgets:mainfrom
Draft
Conversation
martinling
force-pushed
the
sof-filter
branch
3 times, most recently
from
95a90b8 to
59fa7e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds architectural support and UI plumbing for arbitrary filtering in Packetry.
A single filter query is implemented which excludes SOF packets from the capture.
The filter is applied sequentially from the start of the capture, with results appearing incrementally as they become available. Filtering may occur in parallel with loading or capturing. The filter runs in a dedicated thread, and its progress is shown with a progress bar in the UI.
The SOF exclusion query could be written much more efficiently, but serves as a placeholder for arbitrary queries which would include/exclude on a per-item basis.