Set libhackrf version to 0.9.1#1596
Merged
mossmann merged 1 commit intogreatscottgadgets:masterfrom Oct 13, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a change to make our build system more consistent with previous behaviour, and with Semantic Versioning.
In the past, we specified only a
MAJOR.MINORversion for libhackrf in CMake, and also reported that format in the string returned byhackrf_library_version(), e.g.0.9.However, when installing the
.soshared library, we always appended an additonal.0to the version, in order to give a filename such aslibhackrf.so.0.9.0; effectively aMAJOR.MINOR.PATCHversion with thePATCHcomponent hardcoded to zero.PR #1578 / #1586 simplified the version handling in our CMake files, and in the process, accidentally broke the
.sofile versioning completely. PR #1589 fixes that, but now installs a filename oflibhackrf.so.0.9, without aPATCHcomponent.In general, we have a policy at GSG to follow Semantic Versioning. Doing so would dictate that we include a
PATCHcomponent, and that we increment this when we make backwards-compatible fixes that don't add new API.Since shipping libhackrf 0.9 in our 2024.02.1 release package, we have made one backwards-compatible change to the library: the addition of
RAW_IOsupport in PR #1483.Therefore, let's now set the library version to
0.9.1.Since the installation now uses the CMake
PROJECT_VERSIONvariable, this change restores the previous installation behaviour i.e. install an.sofile with aMAJOR.MINOR.PATCHfilename.It also changes the string reported by
hackrf_library_version(), and therefore also byhackrf_info, from0.9to0.9.1.The latter is a user-visible change in behaviour, but one that is consistent with both Semantic Versioning, and with the libhackrf API documentation: which specifies only that the result of that call will be a human-readable string identifying the library version.