fix(OneOf): fail coercion for OneOf is the single field is invalidly provided by a default#4719
Merged
yaacovCR merged 1 commit intographql:17.x.xfrom May 5, 2026
Merged
Conversation
|
@yaacovCR is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
yaacovCR
changed the title
yaacovCR
changed the title
Coercion should fail if there are fewer than one keys pre-coercion. The scenario is a post-coercion single key secondary to a default. Defaults are invalid for OneOf, but this should still fail coercion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR isThis PR was part of a larger effort to standardize across the codebase our treatment of JS-specific valueundefinedas equivalent to absence of the value.But then it turns out that because #4716 only applied to
coerceInputLiteral,coerceInputValueonly checked the post-coercion key number, so the distinction between omitted and undefined didn't matter. But there is a case where it does matter, if we choose to -- and we should -- fail coercion if a OneOf provides no keys but has a single default. This is an invalid case, as defaults are not allowed for OneOf, because they will all be filled in, but we should still fail coercion by checking the pre-coercion number of keys, which would be 0. And once we do that, we should treat undefined the same as omitted!