fix(coerceInputLiteral): null variable input object fields should override defaults#4711
Merged
yaacovCR merged 1 commit intographql:17.x.xfrom May 4, 2026
Merged
Conversation
…ride default PR graphql#3092 added coerceInputLiteral() and was authored by @leebyron. That version preserved explicit null variable values in input object fields by checking whether a variable was missing, not whether its value was nullish. PR graphql#3809 was the rebase of that work by @yaacovCR on top of the fragment variable work. In adapting the lookup to account for fragment variables, the missing-variable check was incorrectly replaced with a nullish value check, causing explicit null variables to be treated as omitted fields. Only missing or explicitly undefined variables should omit/default input object fields. Explicit null variable values must be preserved for nullable fields.
|
@yaacovCR is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3092 added coerceInputLiteral() and was authored by @leebyron. That version preserved explicit null variable values in input object fields by checking whether a variable was missing, not whether its value was nullish.
PR #3809 was the rebase of that work by @yaacovCR on top of the fragment variable work. In adapting the lookup to account for fragment variables, the missing-variable check was incorrectly replaced with a nullish value check, causing explicit null variables to be treated as omitted fields.
Only missing or explicitly undefined variables should omit/default input object fields. Explicit null variable values must be preserved for nullable fields.