Skip to content

Fix mistake in GraphQLError guidance#4706

Merged
yaacovCR merged 1 commit into16.x.xfrom
v17-error-nodes
May 3, 2026
Merged

Fix mistake in GraphQLError guidance#4706
yaacovCR merged 1 commit into16.x.xfrom
v17-error-nodes

Conversation

@benjie
Copy link
Copy Markdown
Member

@benjie benjie commented May 1, 2026

The guidance currently suggests that the second argument to GraphQLError was source but it's actually nodes; here's the type definition for the second argument onward:

type BackwardsCompatibleArgs =
| [options?: GraphQLErrorOptions]
| [
nodes?: GraphQLErrorOptions['nodes'],
source?: GraphQLErrorOptions['source'],
positions?: GraphQLErrorOptions['positions'],
path?: GraphQLErrorOptions['path'],
originalError?: GraphQLErrorOptions['originalError'],
extensions?: GraphQLErrorOptions['extensions'],
];

@vercel
Copy link
Copy Markdown

vercel Bot commented May 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
graphql-js Ready Ready Preview, Comment May 1, 2026 11:43am

Request Review

@yaacovCR yaacovCR merged commit 85700ed into 16.x.x May 3, 2026
37 checks passed
@yaacovCR yaacovCR deleted the v17-error-nodes branch May 3, 2026 13:56
yaacovCR added a commit that referenced this pull request May 6, 2026
## v16.14.0 (2026-05-03)

#### New Feature 🚀
* [#4317](#4317) Allow configuration of the `ofType` introspection depth ([@Nols1000](https://github.com/Nols1000))
* [#4521](#4521) Add experimental support for directives on directive definitions ([@BoD](https://github.com/BoD))

#### Bug Fix 🐞
* [#4652](#4652) Fix valueFromAST variable own-property checks
([@abishekgiri](https://github.com/abishekgiri))

#### Docs 📝
* [#4706](#4706) Fix mistake in GraphQLError guidance ([@benjie](https://github.com/benjie))

#### Committers: 4
* Abishek Kumar Giri([@abishekgiri](https://github.com/abishekgiri))
* Benjie([@benjie](https://github.com/benjie))
* Benoit 'BoD' Lubek([@BoD](https://github.com/BoD))
* Nils-Börge Margotti([@Nols1000](https://github.com/Nols1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants