Skip to content

polish: clean up stream tests #4695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaacovCR merged 1 commit into from
Apr 27, 2026
+12 −38
Merged

polish: clean up stream tests #4695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 6 additions & 19 deletions src/execution/incremental/__tests__/stream-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3851,25 +3851,12 @@ describe('Execute: stream directive (cancellation)', () => {
abortController.abort();
await resolveOnNextTick();

let firstResult:
| IteratorResult<SubsequentIncrementalExecutionResult>
| undefined;
try {
firstResult =
(await nextResultPromise) as IteratorResult<SubsequentIncrementalExecutionResult>;
} catch (error) {
expect(error).to.be.instanceOf(Error);
expect((error as Error).message).to.equal('This operation was aborted');
}
if (firstResult && !firstResult.done) {
try {
const followUp = await iterator.next();
expect(followUp.done).to.equal(true);
} catch (error) {
expect(error).to.be.instanceOf(Error);
expect((error as Error).message).to.equal('This operation was aborted');
}
}
await expectPromise(nextResultPromise).toRejectWith(
'This operation was aborted',
);
await resolveOnNextTick();
const followUp = await iterator.next();
expect(followUp.done).to.equal(true);
expect(streamReturnCount).to.equal(1);

const priorStreamReturnCount = streamReturnCount;
Expand Down
25 changes: 6 additions & 19 deletions src/execution/legacyIncremental/__tests__/legacy-stream-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3640,25 +3640,12 @@ describe('Execute: stream directive (legacy cancellation)', () => {
abortController.abort();
await resolveOnNextTick();

let firstResult:
| IteratorResult<LegacySubsequentIncrementalExecutionResult>
| undefined;
try {
firstResult =
(await nextResultPromise) as IteratorResult<LegacySubsequentIncrementalExecutionResult>;
} catch (error) {
expect(error).to.be.instanceOf(Error);
expect((error as Error).message).to.equal('This operation was aborted');
}
if (firstResult && !firstResult.done) {
try {
const followUp = await iterator.next();
expect(followUp.done).to.equal(true);
} catch (error) {
expect(error).to.be.instanceOf(Error);
expect((error as Error).message).to.equal('This operation was aborted');
}
}
await expectPromise(nextResultPromise).toRejectWith(
'This operation was aborted',
);
await resolveOnNextTick();
const followUp = await iterator.next();
expect(followUp.done).to.equal(true);
expect(streamReturnCount).to.equal(1);

const priorStreamReturnCount = streamReturnCount;
Expand Down
Loading