Skip to content

Update to Go 1.20 and React with line numbers#80

Open
grantnelson-wf wants to merge 3 commits intogopherjs:masterfrom
grantnelson-wf:updateTo1_19
Open

Update to Go 1.20 and React with line numbers#80
grantnelson-wf wants to merge 3 commits intogopherjs:masterfrom
grantnelson-wf:updateTo1_19

Conversation

@grantnelson-wf
Copy link
Copy Markdown

@grantnelson-wf grantnelson-wf commented Dec 9, 2025

I'm doing a lot of experimentation and improvements to the GopherJS playground.

@grantnelson-wf grantnelson-wf changed the title [WIP] Update to Go 1.19 and React with line numbers [WIP] Update to Go 1.20 and React with line numbers Jan 16, 2026
@grantnelson-wf grantnelson-wf force-pushed the updateTo1_19 branch 5 times, most recently from 378a7c1 to e9dfcbe Compare March 24, 2026 22:22
@grantnelson-wf grantnelson-wf changed the title [WIP] Update to Go 1.20 and React with line numbers Update to Go 1.20 and React with line numbers Mar 24, 2026
@grantnelson-wf grantnelson-wf marked this pull request as ready for review March 24, 2026 22:33
Copy link
Copy Markdown
Member

@nevkontakte nevkontakte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be honest and admit that I gave a cursory look to most of the code here.

Personally, I feel like React is a bit of an overkill for what Playground is, but it's an iprovement over the status quo, and if nothing else a pretty useful tech demo, so I have no real objection.

Thanks!

}

// Run load synchronously to await for the package to be available.
srcs, _, err := r.cache.Load(path)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Shadowing here makes recursion a bit more confusing than necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants