Skip to content

Commit 1769f9f

Browse files
danylo1999V8-internal LUCI CQ
authored andcommitted
Revert "[dumpling] Disable timestamp non-determinism."
This reverts commit 597241f. Reason for revert: it didn't help with all timestamps, adding code prefix to mock date looks more promising. Additionally this flag does a bunch of other stuff and requires a build flag to work properly, so let's ditch it. Original change's description: > [dumpling] Disable timestamp non-determinism. > > Quoting Leszek: "--predictable basically disables any concurrency so > that everything is scheduled on the main thread. --verify-predictable > additionally adds a synthetic clock so that things like timestamps have > a fixed value, for being able to verify predictability by hashing" > > Additionally --verify-predictable implies --predictable. > > Bug: 441467877 > Change-Id: I7c47d00b8de8242f4b029e60fe79816713756a2f > Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/9012917 > Reviewed-by: Dominik Klemba <tacet@google.com> > Commit-Queue: Danylo Mocherniuk <mdanylo@google.com> Bug: 441467877 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I8ed49d648aa34a7c75f1ebb220d52a16ee396259 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/9014817 Commit-Queue: Danylo Mocherniuk <mdanylo@google.com> Reviewed-by: Danylo Mocherniuk <mdanylo@google.com> Reviewed-by: Michael Achenbach <machenbach@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
1 parent 6ba00cf commit 1769f9f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

Sources/FuzzilliCli/Profiles/V8DumplingProfile.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ let v8DumplingProfile = Profile(
2828
"--experimental-fuzzing",
2929
"--js-staging",
3030
"--expose-fast-api",
31-
"--verify-predictable",
31+
"--predictable",
3232
"--no-sparkplug",
3333
"--maglev-dumping",
3434
"--turbofan-dumping",
@@ -56,7 +56,7 @@ let v8DumplingProfile = Profile(
5656
"--experimental-fuzzing",
5757
"--js-staging",
5858
"--expose-fast-api",
59-
"--verify-predictable"
59+
"--predictable"
6060
],
6161

6262
processEnv: [:],

0 commit comments

Comments
 (0)