Skip to content

Commit 6ba00cf

Browse files
Danylo MocherniukV8-internal LUCI CQ
authored andcommitted
[dumpling] Add a bit more output.
There are a few more steps to actually report a thing as differential but I don't want to miss anything, so I will print it here too. Bug: 441467877 Change-Id: I009ed1792ae486e55cbd65bf63c0863077a6a375 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/9012880 Reviewed-by: Michael Achenbach <machenbach@google.com> Commit-Queue: Danylo Mocherniuk <mdanylo@google.com>
1 parent 597241f commit 6ba00cf

1 file changed

Lines changed: 14 additions & 1 deletion

File tree

Sources/Fuzzilli/Fuzzer.swift

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1138,7 +1138,20 @@ public class Fuzzer {
11381138

11391139
let unoptimizedDump = try String(contentsOfFile: unoptPath, encoding: .utf8)
11401140

1141-
return DiffExecution.diff(optExec: execution, unoptExec: unoptExecution, optDumpOut: optimizedDump, unoptDumpOut: unoptimizedDump)
1141+
// While Dumpling is not super-stable we print out the program here to not miss anything.
1142+
let result = DiffExecution.diff(optExec: execution, unoptExec: unoptExecution, optDumpOut: optimizedDump, unoptDumpOut: unoptimizedDump)
1143+
1144+
if result.outcome == .differential {
1145+
logger.error("""
1146+
================================================================
1147+
[DUMPLING] POTENTIAL DIFFERENTIAL DETECTED
1148+
================================================================
1149+
""")
1150+
1151+
logger.error(script)
1152+
}
1153+
1154+
return result
11421155

11431156
} catch {
11441157
fatalError("Critical failure: Unable to read dump files. Error: \(error)")

0 commit comments

Comments
 (0)